[PATCH] D77363: Use git-clang-format as Arcanist linter

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 3 11:53:42 PDT 2020


scott.linder added a comment.

In D77363#1960200 <https://reviews.llvm.org/D77363#1960200>, @mehdi_amini wrote:

> I proposed in the original patch to call directly to clang-format-diff.py in-tree instead of looking for an installed version, would you do this instead?


That doesn't seem unreasonable, but we would also need to ensure clang-format is present as the clang-format-diff* script just calls out to it.

If the only guarantee we have across all the packaged versions is that an executable called `clang-format` is in the PATH, then I agree that changing the script to `hash clang-format` and then invoke the in-tree clang-format-diff.py is probably the best we can do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77363/new/

https://reviews.llvm.org/D77363





More information about the llvm-commits mailing list