[PATCH] D77165: libclc: Use temporary files rather than a pipe

Daniel Stone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 3 09:07:51 PDT 2020


daniels added a comment.

In D77165#1959786 <https://reviews.llvm.org/D77165#1959786>, @daniels wrote:

> In D77165#1959565 <https://reviews.llvm.org/D77165#1959565>, @jvesely wrote:
>
> > What was the generator target you used?
>
>
> I'm using Ninja [...]


As noted in D17762 <https://reviews.llvm.org/D17762>, we have to use Ninja rather than the VS backend, as the 'standard' way to add new languages for compile in CMake doesn't work with the VS backend. CMake's VS backend has a hardcoded-in-C++-code list of acceptable source languages; when you try to produce a static library with sources in an unknown-to-CMake-VS-backend language, the target ends up completely empty with no actions to produce the output, because the CMake backend doesn't know how.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77165/new/

https://reviews.llvm.org/D77165





More information about the llvm-commits mailing list