[PATCH] D77227: [RFC][FileCheck] Require colon immediately after CHECK directives

Jonathan Roelofs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 3 08:35:16 PDT 2020


jroelofs added a comment.

In D77227#1959582 <https://reviews.llvm.org/D77227#1959582>, @probinson wrote:

> In D77227#1959041 <https://reviews.llvm.org/D77227#1959041>, @jhenderson wrote:
>
> > Chiming in late, as I only just saw this discussion. I'll be honest, I don't fully follow the explanations. Would it be possible to write up the policy in FileCheck's documentation somewhere?
>
>
> After we figure out what it should be. :-)  But there's a deeper point here, the debate should take place on llvm-dev and not in a review.


Good point. I'll try to summarize our observations / hypotheses so far & start a thread there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77227/new/

https://reviews.llvm.org/D77227





More information about the llvm-commits mailing list