[PATCH] D77133: [mlir] Add an out-of-tree dialect example

Jean-Michel Gorius via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 3 08:02:32 PDT 2020


Kayjukh updated this revision to Diff 254800.
Kayjukh marked 6 inline comments as done.
Kayjukh added a comment.

Remove the `using namespace` directives in the `standalone-opt` source file. This follows standard coding guidelines and code styles of other out-of-tree MLIR projects.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77133/new/

https://reviews.llvm.org/D77133

Files:
  mlir/examples/standalone/CMakeLists.txt
  mlir/examples/standalone/README.md
  mlir/examples/standalone/include/CMakeLists.txt
  mlir/examples/standalone/include/Standalone/CMakeLists.txt
  mlir/examples/standalone/include/Standalone/StandaloneDialect.h
  mlir/examples/standalone/include/Standalone/StandaloneDialect.td
  mlir/examples/standalone/include/Standalone/StandaloneOps.h
  mlir/examples/standalone/include/Standalone/StandaloneOps.td
  mlir/examples/standalone/lib/CMakeLists.txt
  mlir/examples/standalone/lib/Standalone/CMakeLists.txt
  mlir/examples/standalone/lib/Standalone/StandaloneDialect.cpp
  mlir/examples/standalone/lib/Standalone/StandaloneOps.cpp
  mlir/examples/standalone/standalone-opt/CMakeLists.txt
  mlir/examples/standalone/standalone-opt/standalone-opt.cpp
  mlir/examples/standalone/test/CMakeLists.txt
  mlir/examples/standalone/test/Standalone/dummy.mlir
  mlir/examples/standalone/test/lit.cfg.py
  mlir/examples/standalone/test/lit.site.cfg.py.in

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77133.254800.patch
Type: text/x-patch
Size: 20920 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200403/8813d5d4/attachment.bin>


More information about the llvm-commits mailing list