[PATCH] D76073: [compiler-rt][tsan] Fix: Leak of ThreadSignalContext memory mapping when destroying fibers.

[Florian via Phabricator via llvm-commits]

Florian updated this revision to Diff 254782.
Florian edited the summary of this revision.
Florian added a comment.
Herald added a subscriber: jfb.

Making the ThreadFinish call into platform specific code caused all kinds of further issues.
Now the ThreadState itself owns and manages the ThreadSignalContext, as it is required on all supported platforms anyways.

I ran check-tsan multiple times on both my Mac and Linux machine. I also ran clang-tidy and clang-format over it.
I would appreciate it if you could also run the test suite, Dmitry. I am a little scared of breaking something again.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76073/new/

https://reviews.llvm.org/D76073

Files:
  compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
  compiler-rt/lib/tsan/rtl/tsan_rtl.h
  compiler-rt/lib/tsan/rtl/tsan_rtl_thread.cpp
  compiler-rt/test/tsan/fiber_cleanup.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76073.254782.patch
Type: text/x-patch
Size: 7832 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200403/6fdbabdb/attachment.bin>