[PATCH] D77021: [Hexagon] R_HEX_GD_PLT_B22_PCREL cannot be relaxed.

[Sid Manning via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGc484b3e334d3: [Hexagon] Fix issue with non-preemptible STT_TLS symbols (authored by sidneym).

Changed prior to commit:
  https://reviews.llvm.org/D77021?vs=254296&id=254790#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77021/new/

https://reviews.llvm.org/D77021

Files:
  lld/ELF/Relocations.cpp
  lld/test/ELF/hexagon-tls-gd-nonpreemptible.s


Index: lld/test/ELF/hexagon-tls-gd-nonpreemptible.s
===================================================================
--- /dev/null
+++ lld/test/ELF/hexagon-tls-gd-nonpreemptible.s
@@ -0,0 +1,39 @@
+
+# REQUIRES: hexagon
+# RUN: llvm-mc -filetype=obj -triple=hexagon-unknown-elf %s -o %t.o
+# RUN: ld.lld -shared %t.o -o %t.so
+# RUN: llvm-readobj -r %t.so | FileCheck --check-prefix=RELOC %s
+# RUN: llvm-objdump -d --no-show-raw-insn --print-imm-hex %t.so | FileCheck %s
+
+## Prior to D77021 lld would error "relocation R_HEX_GD_PLT_B22_PCREL cannot refer to absolute symbol".
+## A PC-relative relocation referencing a non-preemptible absolute symbol (due to STT_TLS) is not representable in -pie/-shared mode.
+## For this case we will actually patch the symbol to the external __tls_get_addr which is preemptible.
+
+.globl _start
+.type _start, @function
+
+# RELOC:      Section ({{.*}}) .rela.plt {
+# RELOC-NEXT:   R_HEX_JMP_SLOT - 0x0
+# RELOC-NEXT:   R_HEX_JMP_SLOT __tls_get_addr 0x0
+# RELOC-NEXT: }
+
+# CHECK:      { immext(#{{.*}})
+# CHECK-NEXT:   r2 = add(pc,##{{.*}}) }
+# CHECK-NEXT: { immext(#{{.*}})
+# CHECK-NEXT:   r0 = add(r2,##-{{.*}}) }
+# CHECK-NEXT: { call {{.*}} }
+# CHECK-NEXT: { r0 = memw(r0+#0x0) }
+
+_start:
+  r2 = add(pc,##_GLOBAL_OFFSET_TABLE_ at PCREL)
+  r0 = add(r2,##a at GDGOT)
+  call a at GDPLT
+  r0 = memw(r0+#0)
+
+## a is non-preemptible due to STV_HIDDEN visibility.
+## We can achieve the same effect with -Bsymbolic.
+.section        .tdata,"awT", at progbits
+.globl  a
+.hidden a
+a:
+.word 1
Index: lld/ELF/Relocations.cpp
===================================================================
--- lld/ELF/Relocations.cpp
+++ lld/ELF/Relocations.cpp
@@ -1334,7 +1334,10 @@
       // stub type. It should be ignored if optimized to R_PC.
       if (config->emachine == EM_PPC && expr == R_PPC32_PLTREL)
         addend &= ~0x8000;
-      expr = fromPlt(expr);
+      // R_HEX_GD_PLT_B22_PCREL (call a at GDPLT) is transformed into
+      // call __tls_get_addr even if the symbol is non-preemptible.
+      if (!(config->emachine == EM_HEXAGON && type == R_HEX_GD_PLT_B22_PCREL))
+        expr = fromPlt(expr);
     }
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77021.254790.patch
Type: text/x-patch
Size: 2165 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200403/59c6a03b/attachment.bin>