[PATCH] D77383: [FileCheck] Allow parenthesized expressions

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 3 06:57:32 PDT 2020


thopre added a comment.

Should there be some tests under llvm/test/FileCheck as well? Perhaps in numeric-expressions.txt?



================
Comment at: llvm/lib/Support/FileCheckImpl.h:654-660
   /// Parses \p Expr for use of a numeric operand at line \p LineNumber, or
   /// before input is parsed if \p LineNumber is None. Accepts both literal
   /// values and numeric variables, depending on the value of \p AO. Parameter
   /// \p Context points to the class instance holding the live string and
   /// numeric variables. \returns the class representing that operand in the
   /// AST of the expression or an error holding a diagnostic against \p SM
   /// otherwise.
----------------
Maybe mentions parenthesized expression here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77383/new/

https://reviews.llvm.org/D77383





More information about the llvm-commits mailing list