[PATCH] D77360: [mlir][Linalg] Extend linalg,reshape to operate on tensors

[Mahesh Ravishankar via Phabricator via llvm-commits]

mravishankar added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.td:79-81
+    In the strided memref case, depending on whether or not the reassociated
+    MemRefType is contiguous, the resulting memref may require explicit alloc
+    and copies.
----------------
bondhugula wrote:
> This looks problematic. Why add auto in-placing / other arg dependent in-place/out-of-place semantics? Instead, always make it out of place (other passes/utilities can in-place) or have separate ops for in-place and out-of-place?
Could we have a utility function that codifies this semantics. This is a contract that backends have to enforce AFAICS., where such a utility function would be very useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77360/new/

https://reviews.llvm.org/D77360