[PATCH] D72828: [DWARF5] Added support for emission of debug_macro section.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2856-2861
+  if (DD.useSectionsAsReferences())
+    Asm->OutStreamer->emitSymbolValue(
+        Asm->getObjFileLowering().getDwarfLineSection()->getBeginSymbol(), 4);
+  else
+    Asm->OutStreamer->emitSymbolValue(
+        Asm->OutStreamer->getDwarfLineTableSymbol(CU.getUniqueID()), 4);
----------------
Rather than duplicating the code here from  DwarfCompileUnit::initStmtList, please refactor so that this value is computed once and shared from there. (perhaps DwarfCompileUnit can have a getLineTableStartSym function that can be used from here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72828/new/

https://reviews.llvm.org/D72828