[PATCH] D76961: [BranchFolder] don't remove MBB's that have their address taken

Thu Apr 2 18:27:21 PDT 2020

nickdesaulniers added a comment.

In D76961#1958516 <https://reviews.llvm.org/D76961#1958516>, @void wrote:

> In D76961#1958358 <https://reviews.llvm.org/D76961#1958358>, @nickdesaulniers wrote:
>
> > @void would you be opposed to me posting a patch first that preprocessed `llvm/test/CodeGen/X86/callbr-asm-outputs.ll` with `llvm/utils/update_llc_test_checks.py`?
> >
> > I find updating these tests with lots of checks to be a PITA, and it make it easier to maintain this test in the future and see what changed easier with my change.
>
>
> Yeah, go for it.

huh, so it seems that `./llvm/utils/update_llc_test_checks.py llvm/test/CodeGen/X86/callbr-asm-outputs-pred-succ.ll` doesn't actually do anything :( so I don't think I can preprocess it.  I think the output needs to change; I don't understand how you write a test that `update_llc_test_checks.py` is happy with off of the bat.

Worse is that `arc` seems messed up, so I'm not able to post the fix to phabricator.

  $ arc diff
  ...
   Exception 
  Error while loading file "/android1/arcanist/arcanist/src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php": "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?
  (Run with `--trace` for a full exception trace.)

not sure if it auto updated on my host or what.  Is there a way to post to phabricator without `arc`, maybe just `git`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76961/new/

https://reviews.llvm.org/D76961