[PATCH] D76900: Enable IBT(Indirect Branch Tracking) in JIT with CET(Control-flow Enforcement Technology)

Thu Apr 2 17:55:00 PDT 2020

xiangzhangllvm marked an inline comment as done.
xiangzhangllvm added a comment.

> In D76900#1957289 <https://reviews.llvm.org/D76900#1957289>, @hjl.tools wrote:
> 
>> It looks very confusing.   Can you create a diff against master branch, not your last change?
> 
> 
> Never mind.  I couldn't read :-).

This is the whole diff against the master. :-)

================
Comment at: llvm/test/ExecutionEngine/MCJIT/cet-code-model-lager.ll:3
+target triple = "x86_64-unknown-linux-gnu"
+
+ at a = dso_local local_unnamed_addr global i32 1, align 4
----------------
hjl.tools wrote:
> What does this test check?  Does it fail without the fix?
lli will call JIT to compile this code. This test is same with Eli's large code model test. 
This test will run fail if CET enabled JIT not generate endbr for the following 3 functions' entry in CET machine.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76900/new/

https://reviews.llvm.org/D76900