[PATCH] D77133: [mlir] Add an out-of-tree dialect example

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 2 17:22:33 PDT 2020


rriddle accepted this revision.
rriddle added inline comments.


================
Comment at: mlir/examples/standalone/include/Standalone/StandaloneDialect.td:34
+class Standalone_Op<string mnemonic, list<OpTrait> traits = []> :
+        Op<Standalone_Dialect, mnemonic, traits> {
+}
----------------
nit: I don't think you need the {}, you should be able to just close with ';'.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77133/new/

https://reviews.llvm.org/D77133





More information about the llvm-commits mailing list