[PATCH] D77145: [DebugInfo] Fix reading location tables of v5 units in DWP.

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/dwp-v2-loc.s:1-3
+## The test checks that pre-v5 compile units in package files read their
+## location tables from .debug_loc.dwo sections.
+## See dwp-v5-loclists.s for v5 units.
----------------
labath wrote:
> dblaikie wrote:
> > Was this not already tested?
> I was thinking the same thing. The v2 version of this patch (https://reviews.llvm.org/D53155) did include a test case, but that one was based on running llc+dwp. I think that this kind of a test is preferable for testing dumping. I was thinking about deleting the other test, but then then I thought, maybe it is still valueable as it also tests llvm-dwp?
Ah, yep - I'll blame my past lazy self. I've not always been good about doing the Right Thing and adding the llvm-dwarfdump functionality separately (& testing it with object files or assembly tests) then adding the production functionality (& testing that with IR+llvm-dwarfdump). Yep, both testing makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77145/new/

https://reviews.llvm.org/D77145