[PATCH] D77082: [AMDGPU] Handle SMRD signed offset immediate

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM, but would like the same comments copied into the GlobalISel part



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:2876
   const GEPInfo &GEPInfo = AddrInfo[0];
-  if (!GEPInfo.Imm || !isUInt<32>(GEPInfo.Imm))
+  if (!GEPInfo.Imm || GEPInfo.Imm < 0 || !isUInt<32>(GEPInfo.Imm))
     return None;
----------------
Should copy the comment here about the unsigned distinction for the immediate


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77082/new/

https://reviews.llvm.org/D77082