[PATCH] D77321: utils: Tweak clang-parse-diagnostics-file for modules includes

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 2 14:39:05 PDT 2020


dexonsmith closed this revision.
dexonsmith added a comment.

In D77321#1958052 <https://reviews.llvm.org/D77321#1958052>, @arphaman wrote:

> LGTM.


0c85c488e2b5be54ce26c9f772e66d48a9290c51 <https://reviews.llvm.org/rG0c85c488e2b5be54ce26c9f772e66d48a9290c51>

> Looks like we don't have tests for this script, it would be nice to add some in the future, but that shouldn't block this.

Yeah, we're missing tests for most of `llvm/utils` it seems.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77321/new/

https://reviews.llvm.org/D77321





More information about the llvm-commits mailing list