[PATCH] D77319: [WIP] Remove the getNegatibleCost

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 2 11:55:59 PDT 2020


efriedma added a comment.

Can you split whatever change affects the PPC tests into a separate patch, if it's not too tricky?



================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:3531
+  /// Return the newly negated expression if it has, and set the IsProfitable
+  /// if the negated expression is profitable.
   virtual SDValue getNegatedExpression(SDValue Op, SelectionDAG &DAG,
----------------
Maybe expand a little what "profitable" means.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:3549
+
+  /// Return the newly negated expression if it has.
+  SDValue getNegatedExpression(SDValue Op, SelectionDAG &DAG,
----------------
"if it has"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77319/new/

https://reviews.llvm.org/D77319





More information about the llvm-commits mailing list