[PATCH] D77308: [DWARF] Detect extraction errors in DWARFFormValue::extractValue

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Code change LGTM and the tidy-up of block handling in particular is a nice consequence.
I'm not comfortable enough with the test infrastructure used by this patch to click Accept, though.

Re the bool return value, there might have been actual false returns before I worked it over as part of the v5 implementation.  But I don't remember.  I'm moderately sure i wouldn't have introduced an always-true return value on my own.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77308/new/

https://reviews.llvm.org/D77308