[PATCH] D76958: [test-suite] Add support for Hexagon

[Brian Cain via Phabricator via llvm-commits]

bcain marked an inline comment as done.
bcain added a comment.

Any general review disposition for the latest patch w/only changes to `MultiSource/Benchmarks/CMakeLists.txt` and `cmake/modules/DetectArchitecture.c`?



================
Comment at: MicroBenchmarks/libs/benchmark-1.3.0/src/cycleclock.h:85
   return (high << 32) | low;
+#elif defined(__hexagon__)
+  uint64_t  retv;
----------------
lebedev.ri wrote:
> bcain wrote:
> > lebedev.ri wrote:
> > > bcain wrote:
> > > > lebedev.ri wrote:
> > > > > Can you please submit this as a pull request upstream?
> > > > Oh, you bet!  I didn't know we could use PRs.
> > > > 
> > > > There's been a few threads and I've only skimmed them.  Now that you mention it I might've seen one that mentioned test-suite and PRs.
> > > I'm not sure what you mean.
> > > I was only talking about `MicroBenchmarks/libs/benchmark-1.3.0/*` change,
> > > about upstreaming it to  https://github.com/google/benchmark
> > Oh, whoops!  Jumped the gun there.
> > 
> > Ok, will do.  Once it lands there, do I make another review here to pull down the next release of that `benchmark`?  Or does that happen naturally somehow?
> > Ok, will do. Once it lands there, do I make another review here to pull down the next release of that benchmark?
> 
> No, just cherry-pick that commit (note that there are at least 3 copies of `benchmark` within LLVM monorepo,
> so you might want to patch them all at the same time..),
> and add a comment about the cherry-pick into `benchmark/README.llvm`.
> 
> No, just cherry-pick that commit (note that there are at least 3 copies of benchmark within LLVM monorepo,

Ok, will do.  I expect that it may be a while before I can contribute there but I'll get the process started.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76958/new/

https://reviews.llvm.org/D76958