[PATCH] D77285: [llvm-objdump][NFC] Split format-specific interfaces; add namespace

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast marked 2 inline comments as done.
hubert.reinterpretcast added a comment.

Please let me know if there is a preference to post additional patches in parts in the same style or to update this one with the changes associated with the other files when they are all done. Thanks.



================
Comment at: llvm/tools/llvm-objdump/COFFDump.h:13
+#include "llvm/ADT/SmallVector.h"
+#include "llvm/Support/Error.h"
+
----------------
jhenderson wrote:
> Can't you forward-declare `Error` to avoid this include?
Yes, I think so. Will do.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:49
 #include "llvm/Object/ObjectFile.h"
 #include "llvm/Object/XCOFFObjectFile.h"
 #include "llvm/Object/Wasm.h"
----------------
jhenderson wrote:
> It's probably okay to address this clang-format comment here, since you're adding a new include.
D72973 already plans to remove this line.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:77
+using namespace llvm::objdump;
 namespace llvm {
 
----------------
MaskRay wrote:
> Add a new line before `namespace llvm`
Will do; I'll add the same comment to D72973.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77285/new/

https://reviews.llvm.org/D77285