[PATCH] D77289: [Object] Fix crash caused by unhandled error.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 2 06:28:21 PDT 2020


grimar added inline comments.


================
Comment at: llvm/include/llvm/Object/ELFObjectFile.h:631
+    if (Expected<Elf_Sym_Range> SymbolsOrErr = EF.symbols(Sec)) {
+      if (ESym == SymbolsOrErr->begin())
+        return true;
----------------
grimar wrote:
> This condition needs a comment to explain what it does.
And probably no need to add a comment then as `IsNullSymbol` describes nicely what the code does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77289/new/

https://reviews.llvm.org/D77289





More information about the llvm-commits mailing list