[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

[Pratyai Mazumder via Phabricator via llvm-commits]

pratyai added a comment.

It looks like I broke the tests after the `i8 `-> `i1` switch.

I think it's because of an existing bug. From https://llvm.org/docs/LangRef.html

> i1:8:8 - i1 is 8-bit (byte) aligned

OTOH, in `SanitizerCoverage.cpp`, we have in `CreateFunctionLocalArrayInSection()`:

  Array->setAlignment(Align(Ty->isPointerTy()
                               ? DL->getPointerSize()
                               : Ty->getPrimitiveSizeInBits() / 8));

IIUC `getPrimitiveSizeInBits() / 8` would be `1 / 8 => 0` for `i1` type (it works for other `int` types which have multiple-of-8 bits.

PLMK if my assessment is correct, and if so if I should fix it in a separate patch, or just keep that in here.

I'll leave this patch "un-split" for now.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77244/new/

https://reviews.llvm.org/D77244