[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

Looks reasonable to me. Just some nits.



================
Comment at: llvm/cmake/modules/AddLLVM.cmake:1483
+
+  set(arg_path_limit 0)
+  if (ARG_PATH_VALUES)
----------------
Maybe comment what this does?


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:1485
+  if (ARG_PATH_VALUES)
+    # Passign ARG_PATH_VALUES as-is to execute_process() makes cmake strip
+    # empty list entries. So escape the ;s in the list and do the splitting
----------------
typo: Passign -> Passing


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:1495
+
+    list(LENGTH ARG_PATHS len_vars)
+    list(LENGTH ARG_PATH_VALUES len_values)
----------------
Nit: maybe len_vars to match the 'PATHS' name?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77184/new/

https://reviews.llvm.org/D77184