[PATCH] D77289: [Object] Fix crash caused by unhandled error.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/Object/nm-invalid-section-size.test:1
+## This test ensures llvm-nm will not crash when dumping a symbol table
+## whose sh_size isn't a multiple of the symbol size (sh_size % sizeof(Elf_Sym) != 0).
----------------
You should rename this to `invalid-symtab-size.test` and delete the "nm" part of the title. Again, this isn't about testing llvm-nm, but rather the Object library's invalid symbol table section size handling.


================
Comment at: llvm/test/Object/nm-invalid-section-size.test:3
+## whose sh_size isn't a multiple of the symbol size (sh_size % sizeof(Elf_Sym) != 0).
+## TODO: It will be helpful if we could warn about this in future.
+
----------------
will -> would


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77289/new/

https://reviews.llvm.org/D77289