[PATCH] D77144: [NFC] Remove waymarking because it improves performances

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 2 01:36:00 PDT 2020


foad added a comment.

I like this. It's a bit sad that waymarking isn't paying for itself, but if it's not then it should definitely go.



================
Comment at: llvm/include/llvm/IR/Use.h:71
   /// Constructor
-  Use(PrevPtrTag tag) { Prev.setInt(tag); }
+  Use(User *U = nullptr) : Parent(U) {}
 
----------------
Maybe name the argument `Parent` instead of `U`? Does it actually need a default of nullptr?


================
Comment at: llvm/lib/IR/User.cpp:46-47
 
   // Allocate the array of Uses, followed by a pointer (with bottom bit set) to
   // the User.
+  size_t size = N * sizeof(Use);
----------------
Comment needs updating :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77144/new/

https://reviews.llvm.org/D77144





More information about the llvm-commits mailing list