[PATCH] D77231: [lld] Support -emit-asm with LTO

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1937
+  if (config->emitAsm)
+    return;
+
----------------
grimar wrote:
> That the last 2 comments have a large common part. Also it seems that if `thinLTOIndexOnly`, `emitLLVM` and `emitAsm` were added at once and not separatelly, we would not split them. I think it might be better to rewrite these 3 comments into a single one and do:
> 
> ```
> // <A shorter and nicer comment here>
> if (config->thinLTOIndexOnly || config->emitLLVM || config->emitAsm)
>   return;
> ```
"That the last 2..." -> "Last 2..."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77231/new/

https://reviews.llvm.org/D77231