[PATCH] D77232: [mlir][GPUToSPIRV] !!Breaking change!! Make spv.interface_var_abi attribute a required attribute while lowering from gpu.func to spv.func.

Wed Apr 1 23:23:23 PDT 2020

mravishankar marked an inline comment as done.
mravishankar added inline comments.

================
Comment at: mlir/lib/Conversion/GPUToSPIRV/ConvertGPUToSPIRV.cpp:347
+/// Generate default spv.interface_var_abi attributes for lowering gpu.func to
+/// spv.func if no arguments have the attributes set already.
+static LogicalResult
----------------
mehdi_amini wrote:
> The revision title says that it makes "spv.interface_var_abi attribute a required attribute", but this function seems to make it optional?
This is more a escape hatch and is legacy. When I initially set this up it was convenient, but this is very limited in its usage. I would actually prefer to not have this, and any realistic user of the SPIR-V lowering will not be able to use this on many devices. So I can change the comment to make this clearer.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77232/new/

https://reviews.llvm.org/D77232