[PATCH] D77286: [mlir] Enable fusion on conv op if it is a consumer.

Mahesh Ravishankar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 23:23:21 PDT 2020


mravishankar requested changes to this revision.
mravishankar added a comment.

I am not convinced that this is right. The issue with the padding is that you cannot have a subview with padding which can correctly represent the padding in the interior as well as the boundaries. Without going into details, the conv op on subviews is the padded version along the edges, and is the unpadded version in the interior.
The best you can do here is that you can check that the subview is not a result of tiling along the "x" loops of the output, i.e. the size of the subview matches the size of the tensor. You can still tile and fuse along the batch dimension.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77286/new/

https://reviews.llvm.org/D77286





More information about the llvm-commits mailing list