[PATCH] D77285: [llvm-objdump][NFC] Split format-specific interfaces; add namespace

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast created this revision.
hubert.reinterpretcast added reviewers: jhenderson, DiggerLin, jasonliu, daltenty.
Herald added subscribers: rupprecht, MaskRay.
Herald added a project: LLVM.

This patch addresses multiple issues identified with the current structure of `llvm-objdump.h` in the review of D72973 <https://reviews.llvm.org/D72973>.

This patch moves implementation details of the tool into an `llvm::objdump` namespace for external linkage names, splits the implementation details into separate headers for each implementation file, and uses qualified names when declaring members of the `llvm::objdump` namespace in place of leaving the namespace definition open.

Note: In order to gather early feedback, the patch implements only the changes associated with the interfaces implemented by `COFFDump.cpp` at this time.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77285

Files:
  llvm/tools/llvm-objdump/COFFDump.cpp
  llvm/tools/llvm-objdump/COFFDump.h
  llvm/tools/llvm-objdump/llvm-objdump.cpp
  llvm/tools/llvm-objdump/llvm-objdump.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77285.254410.patch
Type: text/x-patch
Size: 6652 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200402/ee51cc4b/attachment.bin>