[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

LGTM
would it be possible to split into 3 patches

1. Instrumentation
2. clang flags stuff
3. compiler-rt test

Btw. is this clang formated?



================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:482
+    Ctor = CreateInitCallsForSections(M, SanCovModuleCtorBoolFlagName,
+                                      SanCovBoolFlagInitName, Int8PtrTy,
+                                      SanCovBoolFlagSectionName);
----------------
Int1PtrT?


================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:918
+    auto Store = IRB.CreateStore(ConstantInt::get(Int8Ty, 1), FlagPtr);
+    Store->setAtomic(AtomicOrdering::Monotonic);
+    Store->setAlignment(llvm::MaybeAlign(FunctionBoolArray->getAlign()));
----------------
Unordered or even NotAtomic is good enough here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77244/new/

https://reviews.llvm.org/D77244