[PATCH] D77227: [RFC][FileCheck] Require colon immediately after CHECK directives

Jonathan Roelofs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 15:12:19 PDT 2020


jroelofs added a comment.

In D77227#1955727 <https://reviews.llvm.org/D77227#1955727>, @jdenny wrote:

> In D77227#1955596 <https://reviews.llvm.org/D77227#1955596>, @probinson wrote:
>
> > Okay, 1500+ tests to fix seems excessive.  Requiring CHECK directives to be on lines by themselves (with optional comment) is more restrictive than the LLVM test suite can tolerate.
>
>
> Maybe the right rule should be that it *either* appears on a line by itself  *or* at the beginning of some single-line comment style (which might not be at the beginning of a line).


So only diagnose if it meets those conditions (with some inferred comment delimiter based on file extension/flag?), but is also missing the colon?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77227/new/

https://reviews.llvm.org/D77227





More information about the llvm-commits mailing list