[PATCH] D77101: [AIX] Return the correct set of callee saved regs

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 12:22:41 PDT 2020


daltenty added a comment.

Posted the NFC patch suggested as D77235 <https://reviews.llvm.org/D77235>

In D77101#1954884 <https://reviews.llvm.org/D77101#1954884>, @sfertile wrote:

> If no one else objects, I would suggest:
>
> 1. Condensing the SVR464 and AIX64 lists to a single list and removing the Darwin lists in an NFC patch.
> 2. Updating this patch to: keep the fatal error you added for `AnyReg` calling convention, then handling isOSAIX() immediately after, with a fatal error if the calling convention  is ColdCC.
>
>   That avoids changing the SplitCSR code which makes it look like its still alive for SVR4 ABIs.  We can then remove SplitCSR in a follow up NFC patch.





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77101/new/

https://reviews.llvm.org/D77101





More information about the llvm-commits mailing list