[PATCH] D77139: GlobalISel: Move code into lowering for G_MERGE_VALUES

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4826
+  if (DstTy.isPointer()) {
+    if (MIRBuilder.getDataLayout().isNonIntegralAddressSpace(
+          DstTy.getAddressSpace())) {
----------------
gargaroff wrote:
> Should this check be done before we create new instructions? Not sure what the current policy for this is. I'm also fine with leaving it down here since it will abort legalization anyway.
I used to try avoiding creating instructions, but as you said it will be deleted


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77139/new/

https://reviews.llvm.org/D77139