[PATCH] D77227: [RFC][FileCheck] Require colon immediately after CHECK directives

[Jonathan Roelofs via Phabricator via llvm-commits]

jroelofs added a comment.

In D77227#1955428 <https://reviews.llvm.org/D77227#1955428>, @probinson wrote:

> Maybe FileCheck should say, that's where directives *have* to be.  Are there real tests where that would be a problem?


Very good question, though I'm not sure what that buys us.

Big plus is that we would be able to skip the massive patch that quotes all the `--check-prefix=` arguments on the RUN lines.

If we require that CHECKs happen within the first N columns (for small N), there'd still be a decision to make as to what to do about ones that are detected beyond that limit. If those are forbidden, then we end up diagnosing use in comments again. If they are silently ignored, I'd argue we've made things worse.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77227/new/

https://reviews.llvm.org/D77227