[PATCH] D76812: [X86] Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [3/3]

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 11:31:44 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86IndirectThunks.cpp:97
+  void populateThunk(MachineFunction &MF) {
+    // This code mitigates LVI by replacing each indirect call/jump with a direct
+    // call/jump to a thunk that looks like:
----------------
Why don't you need the code from retpoline that erases extra BBs?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76812/new/

https://reviews.llvm.org/D76812





More information about the llvm-commits mailing list