[PATCH] D77162: libclc: Fix LLVM library linking on Windows

[Jan Vesely via Phabricator via llvm-commits]

jvesely added a comment.

I think the first part should use `separate_arguments` the same way as `LLVM_CXXFLAGS` does. (you can also add the following change while at it:

  -set( LLVM_CXX_FLAGS ${LLVM_CXX_FLAGS} -fno-rtti -fno-exceptions )
  +list( APPEND LLVM_CXX_FLAGS -fno-rtti -fno-exceptions )

I don't see what the second part is trying to address. Does visual studio not detect the static libraries on the command line? I presume the dynamic versions are not present.
If anything it should check `llvm-config --shared-mode` if available instead of checking for win32. Do all visual studio/clang/mingw use the same flag?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77162/new/

https://reviews.llvm.org/D77162