[PATCH] D77117: [RISCV] Split RISCVISelDAGToDAG.cpp to RISCVISelDAGToDAG.h and RISCVISelDAGToDAG.cpp

Tue Mar 31 20:23:02 PDT 2020

shiva0217 added a comment.

In D77117#1952929 <https://reviews.llvm.org/D77117#1952929>, @lenary wrote:

> @shiva0217 yeah, that sounds good. Please can you ensure you include some of that explanation in the commit message when you land this?

Sure, thanks.

In D77117#1952878 <https://reviews.llvm.org/D77117#1952878>, @luismarques wrote:

> In D77117#1952272 <https://reviews.llvm.org/D77117#1952272>, @shiva0217 wrote:
>
> > For the downstream RISCV maintenance, it would be easier to inherent the RISCVISelDAGToDAG and only override the method need to customize for the custom provider ISA extension without touching RISCVISelDAGToDAG.cpp which may cause conflict when upgrading the downstream LLVM version.
> >  I think it could be helpful for other RISCV downstream maintenance. Could it be the sufficient reason to split out the header?
>
>
> That sounds reasonable.

Thanks for the support.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77117/new/

https://reviews.llvm.org/D77117