[PATCH] D77187: [lld][WebAssembly] Add initial support for -Map/--print-map

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 20:23:01 PDT 2020


ruiu added inline comments.


================
Comment at: lld/wasm/MapFile.cpp:127
+      for (auto *chunk : code->functions) {
+        writeHeader(os, 0, 0, chunk->getSize());
+        os << indent8 << toString(chunk) << '\n';
----------------
Since wasm functions don't have addresses, you decided to print out "0" as an address, right? I wonder if we should something other than "0" (like "-") since "0" is still a valid address.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77187/new/

https://reviews.llvm.org/D77187





More information about the llvm-commits mailing list