[PATCH] D77167: [GraphDiff] Extend GraphDiff to track a list of updates.

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 13:44:41 PDT 2020


asbirlea created this revision.
asbirlea added reviewers: kuhar, dblaikie.
Herald added subscribers: mgrang, george.burgess.iv, hiraditya.
Herald added a project: LLVM.
asbirlea updated this revision to Diff 253981.
asbirlea added a comment.

clang-format.


This patch includes two extensions:

1. It extends the GraphDiff to also keep the original list of updates

after legalization, not just the deletes/insert vectors.
It also provides an API to pop the first update (the updates are store
in reverse, such that the first update is at the end of the list)

2. It adds a bool to mark whether the given updates should be applied as

given, or applied in reverse. This moves the task of reversing the
updates (when the caller needs this) to a functionality inside
GraphDiff, versus having the caller do this.

The two changes could be split into two patches, but they seemed
reasonably small to be reviewed together.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77167

Files:
  llvm/include/llvm/IR/CFGDiff.h
  llvm/include/llvm/Support/CFGUpdate.h
  llvm/lib/Analysis/MemorySSAUpdater.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77167.253981.patch
Type: text/x-patch
Size: 6857 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200331/161a09ef/attachment.bin>


More information about the llvm-commits mailing list