[PATCH] D77164: libclc: Don't pass linker flags to CLC/LLAsm

[Daniel Stone via Phabricator via llvm-commits]

daniels created this revision.
daniels added reviewers: jvesely, tstellar.
Herald added subscribers: llvm-commits, mgorny.
Herald added a project: LLVM.

We don't want the regular linker flags for these invocations, since
we're not compiling to the target machine anyway. This fixes things like
'/machine:x64' being unknown when invoked under Windows.

Depends on: D77163 <https://reviews.llvm.org/D77163>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77164

Files:
  libclc/cmake/CMakeCLCInformation.cmake
  libclc/cmake/CMakeLLAsmInformation.cmake


Index: libclc/cmake/CMakeLLAsmInformation.cmake
===================================================================
--- libclc/cmake/CMakeLLAsmInformation.cmake
+++ libclc/cmake/CMakeLLAsmInformation.cmake
@@ -5,7 +5,7 @@
 
 if(NOT CMAKE_LLAsm_CREATE_STATIC_LIBRARY)
   set(CMAKE_LLAsm_CREATE_STATIC_LIBRARY
-    "<CMAKE_LLAsm_ARCHIVE> <LINK_FLAGS> -o <TARGET> <OBJECTS>")
+    "<CMAKE_LLAsm_ARCHIVE> -o <TARGET> <OBJECTS>")
 endif()
 
 set(CMAKE_INCLUDE_FLAG_LLAsm "-I")
Index: libclc/cmake/CMakeCLCInformation.cmake
===================================================================
--- libclc/cmake/CMakeCLCInformation.cmake
+++ libclc/cmake/CMakeCLCInformation.cmake
@@ -5,7 +5,7 @@
 
 if(NOT CMAKE_CLC_CREATE_STATIC_LIBRARY)
   set(CMAKE_CLC_CREATE_STATIC_LIBRARY
-    "<CMAKE_CLC_ARCHIVE> <LINK_FLAGS> -o <TARGET> <OBJECTS>")
+    "<CMAKE_CLC_ARCHIVE> -o <TARGET> <OBJECTS>")
 endif()
 
 set(CMAKE_INCLUDE_FLAG_CLC "-I")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77164.253966.patch
Type: text/x-patch
Size: 928 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200331/0ab611bb/attachment-0001.bin>