[PATCH] D76252: [lld-macho] Add basic support for linking against dylibs

[Jez Ng via Phabricator via llvm-commits]

int3 marked 8 inline comments as done.
int3 added inline comments.


================
Comment at: lld/MachO/Writer.cpp:357-360
+      os << (char)BIND_OPCODE_SET_SYMBOL_TRAILING_FLAGS_IMM;
+      os << sym->getName() << '\0';
+      os << (char)(BIND_OPCODE_SET_TYPE_IMM | BIND_TYPE_POINTER);
+      os << (char)BIND_OPCODE_DO_BIND;
----------------
ruiu wrote:
> nit: we usually do
> 
>   os << foo << bar
>      << baz << fizz;
> 
> instead of
> 
>   os << foo << bar;
>   os << baz << fizz;
sgtm. Any thoughts on whether we should make a wrapper class like the ByteBuffer in ReaderWriter/MachO? I didn't see a whole lot of usage of `raw_ostream`s in the other lld implementations but I didn't find any abstraction layer over them either


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76252/new/

https://reviews.llvm.org/D76252