[PATCH] D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 10:33:36 PDT 2020


MaskRay added a comment.

> Just a quick question to bounce on what Rui said: why not make this flag -j instead of --threads? Everyone is indeed used to -j. Is there an argument for it being --threads?

@aganea make/ninja/parallel spawn processes (jobs). For an ld, its has a single job. `--threads=` might be a bit implementation specific but I cannot think of a better term expression parallelism within a job...

There is another very weak argument. Because `j` is a prefix of `just-symbols`, GNU style `getopt_long` treats -j as an abbreviation of --just-symbols (which is implemented along with -rpath). If we add `-j` to lld, it can do different things from GNU ld. This makes a short option `-j` less favorable...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76885/new/

https://reviews.llvm.org/D76885





More information about the llvm-commits mailing list