[PATCH] D77149: [Alignment][NFC] Use Align in SelectionDAG::getMemIntrinsicNode

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 09:58:09 PDT 2020


tra added a comment.

LGTM for NVPTX changes.



================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:1616
   GlobalAddressSDNode *Func = dyn_cast<GlobalAddressSDNode>(Callee.getNode());
-  unsigned retAlignment = 0;
+  MaybeAlign retAlignment;
 
----------------
Perhaps make it explicitly `None`? It's not obvious that it's the default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77149/new/

https://reviews.llvm.org/D77149





More information about the llvm-commits mailing list