[PATCH] D77069: [ARM][MVE] Add patterns for VRHADD

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 09:58:04 PDT 2020


SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:2033
+def : Pat<(v16i8 (ARMvshrsImm (add (add (v16i8 MQPR:$Qm), (v16i8 MQPR:$Qn)),
+                                        (v16i8 (ARMvmovImm (i32 3585)))),
+                                   (i32 1))),
----------------
I have seen these constants like the (ARMvmovImm (i32 3585)) here before, but can't remember what they encode. Is that the constant vector of 1s? Is that worth at least a comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77069/new/

https://reviews.llvm.org/D77069





More information about the llvm-commits mailing list