[PATCH] D77090: AMDGPU/GlobalISel: Change intrinsic ID for _L to _LZ opt

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 06:04:39 PDT 2020


arsenm added a comment.

In D77090#1952085 <https://reviews.llvm.org/D77090#1952085>, @Flakebi wrote:

> What is the reason to do this during legalization?
>  Could we look for a constant zero argument during instruction selection?


I think any operand changes should be done during legalization, and selection should be relatively simple. We already do more of this type of conversion during legalize, so I think it makes sense to consolidate it there.

> Then we could also remove the lz variants of the intrinsics and simply encode this as a constant zero argument.

That's what it does now


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77090/new/

https://reviews.llvm.org/D77090





More information about the llvm-commits mailing list