[PATCH] D77135: Provide operand indices to adjustSchedDependency

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 04:23:58 PDT 2020


frasercrmck created this revision.
frasercrmck added reviewers: kparzysz, foad, arsenm, MatzeB.
frasercrmck added a project: LLVM.
Herald added subscribers: llvm-commits, kerbowa, hiraditya, tpr, nhaehnle, wdng, jvesely.

This allows targets to know exactly which operands are contributing to
the dependency, which is required for targets with per-operand
scheduling models.

Required, at least, for our downstream target. I added some seemingly-relevant people from AMDGPU and Hexagon to see if they agree with the idea.

Also, I was tempted to change AMDGPU's and Hexagon's use of `Src` & `Dst` to `Def` & `Use`, as are used in the base method. The discrepancy could be a little confusing.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77135

Files:
  llvm/include/llvm/CodeGen/TargetSubtargetInfo.h
  llvm/lib/CodeGen/MachinePipeliner.cpp
  llvm/lib/CodeGen/ScheduleDAGInstrs.cpp
  llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp
  llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
  llvm/lib/Target/AMDGPU/AMDGPUSubtarget.h
  llvm/lib/Target/Hexagon/HexagonSubtarget.cpp
  llvm/lib/Target/Hexagon/HexagonSubtarget.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77135.253831.patch
Type: text/x-patch
Size: 6088 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200331/078e9871/attachment-0001.bin>


More information about the llvm-commits mailing list