[PATCH] D77128: [MLIR] Implement LoopLikeInterface for loop.parallel

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula requested changes to this revision.
bondhugula added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/lib/Dialect/LoopOps/LoopOps.cpp:479
   assert(ivArg.getOwner() && "unlinked block argument");
   auto *containingInst = ivArg.getOwner()->getParentOp();
   return dyn_cast<ParallelOp>(containingInst);
----------------
Nit: containingOp


================
Comment at: mlir/test/Transforms/loop-invariant-code-motion.mlir:264
+  // CHECK-NEXT: %c8_i32 = constant 8 : i32
+  // CHECK-NEXT: %0 = addi %c7_i32, %c8_i32 : i32
+  // CHECK-NEXT: loop.parallel (%arg0, %arg1) = (%c0, %c0) to (%c10, %c10) step (%c1, %c1)
----------------
You don't need `%0 = `


================
Comment at: mlir/test/Transforms/loop-invariant-code-motion.mlir:266
+  // CHECK-NEXT: loop.parallel (%arg0, %arg1) = (%c0, %c0) to (%c10, %c10) step (%c1, %c1)
+  // CHECK-NEXT:   %1 = addi %arg0, %arg1 : index
+  // CHECK-NEXT:   yield
----------------
You don't need `%1 = `


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77128/new/

https://reviews.llvm.org/D77128