[PATCH] D76908: [lld-macho] Add support for emitting dylibs with a single symbol

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/MachO/Driver.cpp:145-147
+    case OPT_dylib:
+      config->outputType = MH_DYLIB;
+      break;
----------------
Does this have to be in the for loop?


================
Comment at: lld/MachO/Driver.cpp:148-150
+    case OPT_install_name:
+      config->installName = arg->getValue();
+      break;
----------------
Do you have to process this option in a for loop? It looks like you can do somethin glike

  config->outputFile = args.getLastArgValue(OPT_o, "a.out");
  config->installName = args.getLastArgValue(OPT_install_name, config->outputFile);


================
Comment at: lld/MachO/SyntheticSections.h:93
 
+class ExportSection : public InputSection {
+public:
----------------
I'd write a class comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76908/new/

https://reviews.llvm.org/D76908