[PATCH] D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={all,1,2,...} /threads:{all,1,2,...}

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 30 23:25:40 PDT 2020


ruiu added a comment.

Instead of `--threads=all`, can you use `--threads`? `--threads` has several advantages over `--threads=all`:

- it is consistent with other command such as `make`, which takes `-j` for "all" and `-jN` for N threads
- it is compatible with gold
- "all" isn't technically very accurate. A more accurate option name would be something like `--threads=same-as-cpu-threads`, but that's fringe. By eliminating an argument, we can avoid naming it.

If we are doing this, I'd like to see this to be added to the ELF version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76885/new/

https://reviews.llvm.org/D76885





More information about the llvm-commits mailing list