[PATCH] D77098: Restrict test to x86-only

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 30 17:29:50 PDT 2020


MaskRay added a comment.

In D77098#1951328 <https://reviews.llvm.org/D77098#1951328>, @bcain wrote:

> In D77098#1951149 <https://reviews.llvm.org/D77098#1951149>, @MaskRay wrote:
>
> > What problem does this patch solve? llvm-readobj does not depend on lib/Target/* and should not need `REQUIRES: x86-registered-target`
>
>
> Tsk, my mistake, then.  This test fails when -DLLVM_DEFAULT_TARGET_TRIPLE is set to hexagon-unknown-elf and I assumed that it might not make sense to include if x86 wasn't built.


Can you shared the output when `-DLLVM_DEFAULT_TARGET_TRIPLE=hexagon-unknown-elf` is set? If there is an issue we should fix it, but the test is unlikely responsible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77098/new/

https://reviews.llvm.org/D77098





More information about the llvm-commits mailing list