[PATCH] D77004: [MLIR] Fix permuteLoops utility

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 30 15:17:17 PDT 2020


bondhugula marked 3 inline comments as done.
bondhugula added inline comments.


================
Comment at: mlir/test/Dialect/Affine/loop-permute.mlir:26
+// CHECK-120-NEXT:     affine.for
+// CHECK-120-NEXT:       "foo"(%arg4, %arg5)
+// CHECK-120-NEXT:       "bar"(%arg3)
----------------
nicolasvasilache wrote:
> plz use captures instead of SSA names.
This is a different/special scenario - see below the 3! permutations. We don't need to capture the loop IVs anywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77004/new/

https://reviews.llvm.org/D77004





More information about the llvm-commits mailing list